Adding Linux ARM Builds to CI #52
Open
+26
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhard-42
reviewed
Apr 7, 2025
bernhard-42
reviewed
Apr 8, 2025
Collaborator
bernhard-42
left a comment
bernhard-42
left a comment
There was a problem hiding this comment.
Great, looks good.
I think the next step is to check the conditions. Currently I use
if: runner.os == 'Linux'if [[ "$RUNNER_OS" == "Linux" ]]; then
Does the github workflow use these conditions for both intel and arm ubuntu?
And if we need to distinguish, how would that be done.
I currently don't have time to work on it.
However, if we have a tag on the latest working version, then let's merge it and give it a try to learn. If things go south, we can go back to the tag.
Collaborator
|
And another question is, whether we should align the ubuntu version for intel and arm Linux? |
|
Very interested in ARM wheels 🚀 Are you planning to follow up on this? |
Member
Author
|
@Oblynx Eventually. Hopefully there will be more activity after Adam releases OCP 7.9. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.